Use patched version of Internal.TestPlatform.Extensions#2283
Merged
nohwnd merged 1 commit intomicrosoft:masterfrom Jan 10, 2020
Merged
Use patched version of Internal.TestPlatform.Extensions#2283nohwnd merged 1 commit intomicrosoft:masterfrom
nohwnd merged 1 commit intomicrosoft:masterfrom
Conversation
Member
Author
|
This is still waiting for the signed binary which can't be delivered till build outage is solved. |
singhsarab
approved these changes
Jan 10, 2020
nohwnd
added a commit
that referenced
this pull request
Jan 16, 2020
nohwnd
added a commit
that referenced
this pull request
Jan 31, 2020
nohwnd
added a commit
that referenced
this pull request
Feb 3, 2020
* Use patched version of TestPlatform.Extensions (#2283) * Use another patched version of TraceDataCollector * Bump up patched nuget version to avoid caching issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A quick fix for updating Microsoft.Internal.TestPlatform.Extensions that is coming from VS build, the version of the package is tied to all other external packages. The easiest approach to do this is to publish a patched version on myget and change the build script.
This allows updating just a single binary in the package without updating all the other external dependencies.
And avoids hardcoding the version number for just the single package because then we would have to remember it for the next time we update it.
The current package on myget contains non-signed dll at the moment.
Related issue
None